Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

15 fix interactive issue #29

Merged
merged 8 commits into from
Apr 28, 2023
Merged

15 fix interactive issue #29

merged 8 commits into from
Apr 28, 2023

Conversation

mdpadberg
Copy link
Owner

@mdpadberg mdpadberg commented Apr 28, 2023 •
edited
Loading

Thanks for opening this pull request

Please check if all the following actions are taken:

  • The title of this pull request clearly describes what the code is doing
  • This pull request contains one or more labels
  • This pull request is linked to one or more related issues
  • This pull request contains extra tests to cover the use cases of the new or changed code
  • The build for this pull request is green

@mdpadberg mdpadberg added the bug Something isn't working label Apr 28, 2023
@mdpadberg mdpadberg linked an issue Apr 28, 2023 that may be closed by this pull request
Fix interactive issue #15
Closed
vplme
vplme approved these changes Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@vplme vplme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mdpadberg mdpadberg merged commit e178574 into main Apr 28, 2023
@mdpadberg mdpadberg deleted the 15-fix-interactive-issue branch April 28, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vplme vplme vplme approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix interactive issue
2 participants
@mdpadberg @vplme