Small improvements #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 21, 2014 11:32
… not contenteditable
|
Hey @TacoDeWolff, the changes for the menu changes look good, could we keep the CSS in the editor for now and refactor that into a separate style sheet later? It takes away styling currently from the demo, thanks! |
|
Excellent, sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed standard CSS from the body tag, it interferes with my styling and it is unnecessary.
Menu now hides when clicking outside the editor. I believe this is expected behaviour, I myself kept clicking outside only to note the menu never hides that way. Which is weird...
Unable to select whitespace, you can't and shouldn't apply styling to whitespace.
Clicking a button in menu now only works with the left mousebutton, this is expected and default button behaviour.
What I think should be implemented is that selected text is trimmed of whitespace at the beginning and end. So if you select "Hello " it will style "Hello" and exclude the trailing whitespace.