-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: insert markdown content at the current selection point. #256
Conversation
Thank you! I will review this in the upcoming days. |
Great to see we have V2.0 released. I will push a new revision to adapt the MDXEditor-2.0 soon |
@forhappy I'm actually thinking that this could be a core feature, rather than a plugin. Let me play with an idea I have around a possible implementation, I want to run this by you and see if it makes sense. |
Thank you for the help, really appreciated ;) |
While I am experimenting with the MDXeditor V2 features I found out there are a few cells not being publicly exported:
Those cells are useful to write custom import plugins, those concepts are available in V1, can we export those cells in V2 as well? |
@forhappy all of those have their respective |
Hey @petyosi, I need to access those cell values in my own markdown manipulation plugin, however those cells are not exported. |
Is there any way I can just use useCellValue to retrieve the import visitors? |
That makes sense. I understand that need them, exporting them is not a big deal, you can PR that, I will merge quickly. Like I mentioned, I want to make what you're describing a core feature, while avoiding the node you've introduced. But I seem to be taking my time on it, sorry for that. |
Yes, you can :). the |
Looks like those were not exported in core/index.d.js, I can see those cells exported in core/index.js though. |
I closed this PR and may think about to raise a new PR based on MDXEditor V2 API ;) |
Hello @petyosi, Will you be able to export the above cells? I can create a PR if needed. |
With this feature we can now support inserting markdown content at the current selection point after the editor initialized, this feature will be useful in use case where the user needs to programmatically append/insert markdown content.