Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo and path for shortcodes #1009

Merged
merged 2 commits into from
Apr 13, 2020
Merged

fix typo and path for shortcodes #1009

merged 2 commits into from
Apr 13, 2020

Conversation

mohrash92
Copy link
Contributor

@mohrash92 mohrash92 commented Apr 11, 2020 •
edited
Loading

Change makeShortcodes to makeShortcode and fix broken link to shortcodes page

@vercel
Copy link

vercel bot commented Apr 11, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/mdx/mdx/847wi1guf
✅ Preview: https://mdx-git-fork-mohrash92-mohrash92-patch-1.mdx.now.sh

@vercel vercel bot temporarily deployed to Preview April 11, 2020 18:19 Inactive
johno
johno approved these changes Apr 13, 2020
View reviewed changes
Copy link
Member

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! For now we'll need to keep the link the same so that it continues to work on mdxjs.com though we should probably add a plugin which allows us to use links that are github-compatible for the website which would be a separate issue.

@vercel vercel bot temporarily deployed to Preview April 13, 2020 13:45 Inactive
@johno johno merged commit a2be43f into mdx-js:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johno johno johno approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohrash92 @johno