Add HMR to example of MDX w/ Vite #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wooorm
reviewed
Apr 17, 2024
Co-authored-by: Titus <[email protected]> Signed-off-by: Dan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2474 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 2693 2709 +16
Branches 2 2
=========================================
+ Hits 2693 2709 +16 ☔ View full report in Codecov by Sentry. |
wooorm
approved these changes
Apr 17, 2024
wooorm
changed the title
|
Thanks! |
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
I have updated the docs for
@mdx-js/rollup: I added the suggestion fromvite-plugin-reactsincludeoption by addingmdxto the list to enable HMR.Without it, a full page reload is required, and it took me some time to figure that out. I think one almost always wants that to be enabled.