Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 54 #55

Merged
merged 15 commits into from
Nov 14, 2021
Merged

Issue 54 #55

merged 15 commits into from
Nov 14, 2021

Conversation

kmaasrud
Copy link
Member

@kmaasrud kmaasrud commented Nov 13, 2021

  • Move over wikilink parsing
  • Move over KaTeX div/span generation
  • Move over front matter parsing
  • Move over README -> index conversion
  • Allow turning on/off each preprocessor
    • Toggle for each default preprocessor in the config, to compliment the disable_default_preprocessors toggle.

Motivation

Publishing and maintaining our preprocessors as separate crates has proven to be very tedious. We would thus like a local preprocessor that mdzk utilizes, which we will not have to maintain separately. This should also increase performance, as we can do a lot of the preprocessing over the same iteration.

@kmaasrud kmaasrud linked an issue Nov 13, 2021 that may be closed by this pull request
@kmaasrud kmaasrud self-assigned this Nov 13, 2021
@kmaasrud
Copy link
Member Author

@ratsclub I've not moved mdbook-backlinks over, as the next step to tackle is to redo the backlinks handling. Could you check to see if every preprocessor works as expected?

You can test the disabling feature with these configuration values:

[build]
# ...
front-matter = false
math = false
readme = false
wikilinks = false

@kmaasrud kmaasrud marked this pull request as ready for review November 13, 2021 18:21
@kmaasrud kmaasrud requested a review from ratsclub November 13, 2021 18:21
@kmaasrud kmaasrud removed the request for review from ratsclub November 14, 2021 10:04
@kmaasrud kmaasrud merged commit 4405758 into main Nov 14, 2021
@kmaasrud kmaasrud deleted the issue-54 branch November 14, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make monolithic preprocessor
1 participant