Add doc blocks, type hinting. Make stricter. #1
Conversation
| @@ -9,10 +9,24 @@ class Curried | |||
| */ | |||
| private $func; | |||
|
|
|||
| /** | |||
| * @var array | |||
There was a problem hiding this comment.
yeah I'm going to veto this bit of the change. It doesn't seem to add any additional information
There was a problem hiding this comment.
How about mixed[] - it would indicate an Array of variable types 🤔
There was a problem hiding this comment.
good point. I think I like mixed[] better as it's more explicit that we expect a mix rather than just didn't bother specifying the type.
| private $arity; | ||
|
|
||
| public function __construct($callable, $arity = null) | ||
| /** | ||
| * Curried constructor. |
There was a problem hiding this comment.
The @param s I like but I'd remove 'Curried constructor.' as it doesn't add any extra information,
There was a problem hiding this comment.
PHPStorm default - don't even notice them any more. Can remove 😄
There was a problem hiding this comment.
yeah it's a pet peeve of mine comments that say things like "add one to x". I probably spend more time than is sensible editing phpstorm's defaults.
| @@ -24,18 +38,26 @@ public function __construct($callable, $arity = null) | |||
| public function __invoke() | |||
| { | |||
| $arguments = func_get_args(); | |||
| if (count($this->args) == $this->arity - count($arguments)) { | |||
| if (count($this->args) === $this->arity - count($arguments)) { | |||
| private $object; | ||
|
|
||
| /** | ||
| * CurryWrapper constructor. |
There was a problem hiding this comment.
I'd remove the string "CurryWrapper" constructor as it doesn't add any extra information.
| private $args = []; | ||
|
|
||
| /** | ||
| span class="pl-s1"> * @var integer |
There was a problem hiding this comment.
I think you may have slipped on your keyboard here 😆 🤣
Everyone likes doc blocks.