feat: add delete option to three dots menu #4842
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great to see this feature implemented. A minor suggestion: I believe that the best practice in terms of UX is to place the 'Delete' action as the last item in the menu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR adds the "Delete" option to the three dots menu. Excluding delete from the three dots menu has caused confusion as seen in #3984 (comment)
Before:
After:
Which issue(s) this PR fixes:
No issue, but feature request is here: #3984 (comment)
Special notes for your reviewer:
This may have been omitted intentionally from the three dots menu, considering all the plumbing was already in place and I just had to flip the value to
true. Was this omitted for a good reason to where we actually don't want to allow this?Testing
I tested manually, but I'm not sure where test coverage should be added. Please advise.