only enabling morgan logger if config.log.format option was defined, …

…and disabling the app.log file transport option for the test environment
meanjs · May 19, 2016 · 5b9b2fd · 5b9b2fd
1 parent 1f75f9f
commit 5b9b2fd
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/config/env/test.js b/config/env/test.js
@@ -15,14 +15,14 @@ module.exports = {
   log: {
     // logging with Morgan - https://github.com/expressjs/morgan
     // Can specify one of 'combined', 'common', 'dev', 'short', 'tiny'
-    format: 'combined',
-    fileLogger: {
-      directoryPath: process.cwd(),
-      fileName: 'app.log',
-      maxsize: 10485760,
-      maxFiles: 2,
-      json: false
-    }
+    format: 'dev'
+    // fileLogger: {
+    //   directoryPath: process.cwd(),
+    //   fileName: 'app.log',
+    //   maxsize: 10485760,
+    //   maxFiles: 2,
+    //   json: false
+    // }
   },
   port: process.env.PORT || 3001,
   app: {

diff --git a/config/lib/express.js b/config/lib/express.js
@@ -18,6 +18,7 @@ var config = require('../config'),
   flash = require('connect-flash'),
   consolidate = require('consolidate'),
   path = require('path'),
+  _ = require('lodash'),
   lusca = require('lusca');
 
 /**
@@ -68,8 +69,10 @@ module.exports.initMiddleware = function (app) {
   // Initialize favicon middleware
   app.use(favicon(app.locals.favicon));
 
-  // Enable logger (morgan)
-  app.use(morgan(logger.getLogFormat(), logger.getMorganOptions()));
+  // Enable logger (morgan) if enabled in the configuration file
+  if (_.has(config, 'log.format')) {
+    app.use(morgan(logger.getLogFormat(), logger.getMorganOptions()));
+  }
 
   // Environment dependent middleware
   if (process.env.NODE_ENV === 'development') {