Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Gruntfile not being linted #1125

Closed
JulianLaval opened this issue Jan 1, 2016 · 2 comments · Fixed by #1135
Closed

Gruntfile not being linted #1125

JulianLaval opened this issue Jan 1, 2016 · 2 comments · Fixed by #1135
Assignees
@codydaig
Labels
issue:bug need:pr_required
Milestone
0.5.0

Comments

@JulianLaval
Copy link
Contributor

Hi there,

As it stands, the Gruntfile makes use of the Lodash union method to specify the ESLint target:

_.union(defaultAssets.server.gruntConfig, defaultAssets.server.allJS, defaultAssets.client.js, testAssets.tests.server, testAssets.tests.client, testAssets.tests.e2e)

This method only operates on arrays, however, and so the gruntConfig property in the default assets (a string) isn't being added to this union.

May I suggest changing the field in config/assets/default.js from gruntConfig: 'Gruntfile.js' to gruntConfig: ['Gruntfile.js'] so that it may be linted as expected?

Happy to submit a PR!
@codydaig
Copy link
Member

codydaig commented Jan 1, 2016

@JulianLaval Go ahead and submit a PR and we'll review!

@codydaig codydaig self-assigned this Jan 1, 2016
@codydaig codydaig added this to the 0.5.0 milestone Jan 1, 2016
@mleanos
Copy link
Member

mleanos commented Jan 2, 2016

The proposed fix looks right to me. Thanks.

@JulianLaval JulianLaval mentioned this issue Jan 14, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@codydaig codydaig

Labels
issue:bug need:pr_required
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

fix(config): Added Gruntfile linting
3 participants
@JulianLaval @codydaig @mleanos