This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
fix(config): Added Gruntfile linting #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -59,7 +59,7 @@ Fixes #82 | |||
| * The scope should be where the change took place. | |||
| * Examples: users, core, config, articles | |||
| * Subject: | |||
| * The subject line should be clear and consice as to what is being accomplished in the commit. | |||
| * The subject line should be clear and concise as to what is being accomplished in the commit. | |||
There was a problem hiding this comment.
Different PR just because it's separate from the purpose of this one.
|
LGTM other than the typo, which should probably be in a separate PR because it fixes something different. |
|
Fair enough! Assumed that since the change was minor, it could be bundled with this PR - will go ahead and update this one / create a new one for the typo. |
Changed config properties to arrays for inclusion in Gruntfile Lodash unions, e.g. linting Fixes #1125
ilanbiala
added a commit
that referenced
this pull request
Jan 14, 2016
fix(config): Added Gruntfile linting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed config properties to arrays for inclusion in Gruntfile Lodash unions, e.g. linting. Also fixes typo in CONTRIBUTING.md
Fixes #1125