Remove in Article -> Add callback

[marianoqueirel]

mean/modules/articles/client/controllers/articles.client.controller.js

function remove() {
  if ($window.confirm('Are you sure you want to delete?')) {
    vm.article.$remove($state.go('articles.list'));
}

I think it would be better to do as follow:

function remove() {
  if ($window.confirm('Are you sure you want to delete?')) {
    vm.article.$remove(function (){
      $state.go('articles.list'));
    });
}

In Order to do so with a callback, and so it en the next digest.

[ilanbiala]

@marianoqueirel there should actually be error handling as well. Can you make a PR so we can fix this code a bit?

[jamviking]

There is a typo here: $state.go('articles.list'));
It should be: $state.go('articles.list');

This patch actually fixes a bug in 0.5 where the list sometimes still displays the deleted record after deletion.

I have not observed the bug in 0.4.2.

[ilanbiala]

@marianoqueirel can you make a PR with your code with @jamviking's typo fix?

[marianoqueirel]

sure! @ilanbiala, I'm going to do, and Make my first PR.

[xiandalisay]

I'm also experiencing this issue. I deal with images associated with the article.

The 'news.list' was called even if the remove function has not finished executing (1 out 5 images has been deleted the moment 'news.list' was called). Thanks @marianoqueirel for the solution.

[lirantal]

@xiandalisay , @marianoqueirel will you open a PR please to fix this?

[lirantal]

@ilanbiala @xiandalisay @marianoqueirel one of you would like to open a PR for this fix?
@hyperreality or you? :)

[hyperreality]

@lirantal Sure, I'll take a look at it sometime in the next few days.