-
Notifications
You must be signed in to change notification settings - Fork 2k
Conversation
@ilanbiala This is failing on Node 0.10. |
So it turns out that to upgrade to Karma 0.13, we can no longer use npm 1.4.28 because the way it handles peerDeps is different and https://travis-ci.org/meanjs/mean/jobs/88529913#L429 these errors are because of the old semver used I believe. In any case, @lirantal @codydaig @mleanos @jloveland what do you guys think about this? Eventually we'll want to update Karma, and I think we can just ask people to use npm >=2 in engines, right? We can make this change in 0.5.0 if you guys agree. I'm open to other suggestions too. |
@ilanbiala I'm all for dropping 0.10 support in 0.5.x to get this merged in. |
Yeah, 0.10.0 was released in 2013, and 0.12 has been around and io.js and Node 4, so I think most of the people have moved to Node 0.12 if not higher. Also, this will allow us to start using ES6. |
Unless @lirantal has any objections too this, once 0.4.2 is released, we can remove 0.10 from the travis builds. |
I'm ok. |
@ilanbiala Can you update the commit message and rebase? I think this is ready os go. |
e9bc850
to
5015699
Compare
5015699
to
e064178
Compare
@codydaig some weird stuff happened in the rebase. I think I'm just going to create a new PR. |
No worries. It happens. |
Fixes #1015