Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Fix npm warnings #1041

Closed
wants to merge 1 commit into from
Closed

Fix npm warnings #1041

wants to merge 1 commit into from

Conversation

ilanbiala
Copy link
Member

Fixes #1015

@codydaig
Copy link
Member

@ilanbiala This is failing on Node 0.10.

@ilanbiala
Copy link
Member Author

So it turns out that to upgrade to Karma 0.13, we can no longer use npm 1.4.28 because the way it handles peerDeps is different and https://travis-ci.org/meanjs/mean/jobs/88529913#L429 these errors are because of the old semver used I believe. In any case, @lirantal @codydaig @mleanos @jloveland what do you guys think about this? Eventually we'll want to update Karma, and I think we can just ask people to use npm >=2 in engines, right? We can make this change in 0.5.0 if you guys agree. I'm open to other suggestions too.

@codydaig
Copy link
Member

@ilanbiala I'm all for dropping 0.10 support in 0.5.x to get this merged in.

@ilanbiala
Copy link
Member Author

Yeah, 0.10.0 was released in 2013, and 0.12 has been around and io.js and Node 4, so I think most of the people have moved to Node 0.12 if not higher. Also, this will allow us to start using ES6.

@codydaig codydaig added this to the 0.5.0 milestone Nov 1, 2015
@codydaig
Copy link
Member

codydaig commented Nov 1, 2015

Unless @lirantal has any objections too this, once 0.4.2 is released, we can remove 0.10 from the travis builds.

@lirantal
Copy link
Member

lirantal commented Nov 1, 2015

I'm ok.

@codydaig
Copy link
Member

@ilanbiala Can you update the commit message and rebase? I think this is ready os go.

@ilanbiala
Copy link
Member Author

@codydaig some weird stuff happened in the rebase. I think I'm just going to create a new PR.

@codydaig
Copy link
Member

No worries. It happens.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants