This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Add data container for docker-compose and update to docker compose version 2 #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 19, 2016 22:15
Change containers, add environment for mongodb host, change version to 2. Fixes meanjs#1434
Add db-data for mongodb, remove container_name. Fixes meanjs#1434
Remove links Fixes meanjs#1434
Add depends_on for db Fixes meanjs#1434
Add data container, add volumes and remove command. Fixes meanjs#1434
Change busybox to build . for data container Fixes meanjs#1434
Change entrypoint for web-data container Fixes meanjs#1434
|
I will test this dev config later this week and merge if it works well. |
|
Tested, looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(deploy) Add data container for docker-compose and update to docker compose version 2.
Add data container for mongodb
Add data container for web data
Update to compose version 2
Use networking of compose version 2 (remove links)
Use depends_on for containers
Fixes #1434