This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Adds a generic DOMAIN configuration environment #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generic DOMAI configuration environment variable, useful for setting links to an app in reset email templates, and other cases. Fixes meanjs#871 and meanjs#847
| @@ -9,6 +9,9 @@ module.exports = { | |||
| }, | |||
| port: process.env.PORT || 3000, | |||
| host: process.env.HOST || '0.0.0.0', | |||
| // DOMAIN config should be set to the fully qualified application accessible | |||
| // URL. For example: https://www.myapp.com (including port if required). | |||
| domain: process.env.DOMAIN, | |||
There was a problem hiding this comment.
If not set, should this default to localhost? Or at least default to localhost in the development config?
There was a problem hiding this comment.
We kind of take care of that in https://github.com/meanjs/mean/pull/1469/files/77d4a990f52b83d684a6eb73c7e019576163467e#diff-c3841fb7af244bab7b73ea4c3d72055cR64
It also makes it much complicated to default it to something because you don't know if the server is running in http or https, and this causes many more logic tests to run. It's a simple domain/url setting, I don't think we need to make it anymore complex than that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic DOMAI configuration environment variable, useful for setting links to an app
in reset email templates, and other cases.
Fixes #871 and #847