This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Remove executable bit when not necessary #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The executable bit is set for a lot of files where it is not necessary to have the executable bit set. This PR removes the executable bit from those files.
|
Does this actually have any effect? Most of those can't be run anyway, right? |
|
This is a cleanup. It looks ugly and wrong to have a |
|
What about server.js, doesn't |
|
It is not necessary to set |
|
@lirantal LGTY? |
|
Hey, Definitely agree with @berendt. I saw this coming in on e-mail earlier today and wanted to approve but I'm only getting to working from home now. It's a good cleanup, I'll merge. |
lirantal
added a commit
that referenced
this pull request
Feb 16, 2015
Remove executable bit when not necessary
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The executable bit is set for a lot of files where it is not necessary
to have the executable bit set. This PR removes the executable bit from
those files.