Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Added peer dependencies to package.json file to work with npm3 #654

Closed
wants to merge 2 commits into from

Conversation

codydaig
Copy link
Member

No description provided.

@lirantal
Copy link
Member

Hey @codydaig

  1. I'm not really sure what's this PR trying to solve, can you explain a bit? I'm seeing added packages like paypal, grunt, jasmine-core, what are they added for?
  2. Please squash to one commit.

@codydaig
Copy link
Member Author

For npm3 (which is still in beta), it will no longer automatically install peer dependencies. Currently, if your running the latest version of npm, it will spit out a WARN message every time a module has a peer dependency that is not already listed as a dependency in the package.json file.

More info here: http://blog.npmjs.org/post/110924823920/npm-weekly-5

The paypal line change wasn't an addition, it was a spacing inconsistency, but I believe that got resolved in the validator.js pull request that was just merged in.

I'm submitting a new pull request that has the two commits squashed. #658

@lirantal
Copy link
Member

Cool, closing this one.

@lirantal lirantal closed this Jul 17, 2015
@codydaig codydaig deleted the npm3-patch1 branch July 22, 2015 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants