This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
[test] Allow an email with sub domains #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Thanks @codydaig, glad to see that the tests actually caught something for you! P.S. I'll merge but I think I'm seeing still a problem there with the tests in general (mine included) which need to be addressed |
lirantal
added a commit
that referenced
this pull request
Aug 20, 2015
[test] Allow an email with sub domains
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lirantal Great job on the email tests you added. I took that and added it against my group's project and they all passed, but when I added the following it failed. It currently passes in the MEAN.js project, but I think it's worth checking for in case we switch validators down the road.