This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
[fix] Was storing a 6 char password in plain text [fixes #829] #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank u guys for maintaining this awesome project |
|
LGTM. Good catch @sparshy |
|
LGTM |
|
Thanks guys, good catch indeed @sparshy |
lirantal
added a commit
that referenced
this pull request
Aug 21, 2015
[fix] Was storing a 6 char password in plain text [fixes #829]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #829.
If the password was exactly 6 characters long, the password would not get hashed and was being stored in the database as plain text. I added a couple tests to ensure the password wasn't being stored in plain text as well as fixed the logic that was skipping over the password hashing.
Thanks @sparshy! :-D