Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

[fix] Fixed Facebook Auth [Closes #697] #839

Closed
wants to merge 1 commit into from

Conversation

codydaig
Copy link
Member

Per the Facebook Docs: https://developers.facebook.com/docs/graph-api/reference/v2.3/user

There is no emails field, it is only email

Closes #697

@lirantal
Copy link
Member

Thanks @codydaig
Would be helpful if someone can actually test it to confirm though I think going by the docs is also ok for now.

@lirantal lirantal added this to the 0.4.x milestone Aug 22, 2015
@lirantal lirantal self-assigned this Aug 22, 2015
@codydaig
Copy link
Member Author

@rhutchison @trainerbill @mleanos

I made this change on mean.codydaig.me and set-up a facebook app id and secret. However, upon login, I'm getting a not-found error. Any suggestions on where to start looking?

@codydaig
Copy link
Member Author

@lirantal I'm testing this. Don't merge this in.

@rhutchison
Copy link
Contributor

This is not a bug/fix, passport-facebook takes care of the translation (map) before making a request.

#697 is more likely an issue because of the details in #202 - someone denied authorization to email and it fails because there is nothing to prevent invalid index.

@codydaig
Copy link
Member Author

@rhutchison I'll close for now. Thanks!

@codydaig codydaig closed this Aug 23, 2015
@codydaig codydaig deleted the bug/facebookAuth branch August 26, 2015 04:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants