This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Renamed files using convention verb-object.client... #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
1 similar comment
|
LGTM |
|
@vaucouleur this PR has conflicts now after we merged the facebook PR and #759 |
|
@lirantal I just rebased using upstream. Can you please try again. |
|
Thanks @vaucouleur LGTM |
|
LGTM as well |
|
LGTM |
Renamed files using convention verb-object.client.etc. Closes #817
|
Still LGTM Thanks @vaucouleur for keeping up on this PR with all the changes and rebases. |
|
Tested. LGTM. |
ilanbiala
added a commit
that referenced
this pull request
Aug 27, 2015
Rename files using convention verb-object.client
|
@lirantal just fyi I merged so @rhutchison could continue working on something that needs this. |
|
Of course, no problems. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed files using file naming convention: verb-object.client...
Closes #817