This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Admin users require role #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes make the role field required in the User model. Changes to the Admin user edit view were added to provide validation for the role field. As an added enhancement, the user's roles are displayed in the Admin user list view.
Added tests for the User model's roles field. Should be able to update existing user with valid roles Should NOT be able to update existing user WITHOUT a role Should NOT be able to update existing user with INVALID role
|
LGTM |
|
Looks good. I want to merge my additions to the user model tests for and then you can probably rebase again for the conflicts |
|
Looks like we're good here to merge. |
mleanos
added a commit
to mleanos/mean
that referenced
this pull request
Aug 30, 2015
PR meanjs#840 changed the global var `user` to `user1`. This was merged and then meanjs#858 was merged, which was still referencing the global var as `user` in the new *roles* tests. This was causing jshint failures from the new This change updates the new *roles* tests to use `user1`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make the role field required in the User model. Changes to
the Admin user edit view were added to provide validation for the role
field.
As an added enhancement, the user's roles are displayed in the Admin
user list view.
Added model tests to accommodate these changes.