This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
[bugfix] Fixes bug with db seed user passwords #931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a static schema method to the User schema to generate a random passphrase, that passes the owasp strength test. Updated the db seed configuration to use a randomly generated passphrase from the new User schema method, as the passwords for the seeded users. Added the generate-password package to the project.
Added a User model test for the generateRandomPassphrase schema method.
|
No worries @mleanos, I'm ok with the promise-based approach. |
|
LGTM @lirantal As I said in the other PR, which ever PR is going to make your refactor easier, go ahead and merge that one. |
|
Closing since #921 was merged in lieu of this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lirantal This PR is an alternative to #921 You may prefer this one as it is much simpler and has very little changes to the db seed configuration. I know you want this fix merged ASAP. Whatever your preference, is fine by me. This PR & #921 work to fix the bug.
Added a static schema method to the User schema to generate a random
passphrase, that passes the owasp strength test.
Updated the db seed configuration to use a randomly generated passphrase
from the new User schema method, as the passwords for the seeded users.
Added the generate-password package to the project.