-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uploading Email auditing API YAML #11
base: master
Are you sure you want to change the base?
Conversation
New Email auditing API.
responses: | ||
"200": | ||
content: | ||
application/octet-stream: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Content-Type returned by the API should be application/gzip
to be in compliance with standards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though Eng confirmed your suggestion as a specific Content-Type for gzip files, they're returning application/octet-stream
:(
email-auditing-api.yaml
Outdated
Lists all the Experience programs or Ad Hoc surveys to audit emails from. | ||
operationId: listPrograms | ||
parameters: | ||
- description: Position of the Experience program or Ad Hoc survey in the list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
position
is not intuitive as to what you're meaning. This is a "page offset"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but as the name of the param is Offset didn't want to end up in a tautology.
New Email auditing API.