Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7128-Medic rebrand #195

Merged
merged 3 commits into from
Jul 22, 2021
Merged

7128-Medic rebrand #195

merged 3 commits into from
Jul 22, 2021

Conversation

latin-panda
Copy link
Contributor

@latin-panda latin-panda commented Jul 19, 2021

Description

This PR:

  • Updates the icon of the mobile app according with the rebrand.
  • Updating the app_name from Medic Mobile to Medic, copyright & license stays the same as legal name still is Medic Mobile, Inc.

Ticket: medic/cht-core#7128
CHT-Core: medic/cht-core#7204

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@latin-panda latin-panda requested a review from njogz July 19, 2021 10:30
@latin-panda
Copy link
Contributor Author

Hi @njogz, can you please review? Thanks!

@mrsarm
Copy link
Contributor

mrsarm commented Jul 19, 2021

Hey @latin-panda , please rebase your branch with the latest changes from master, I have disabled the instrumentation tests until #196 is fixed. The error in CI you got is not exactly the same but related, and will also fixed later.

@latin-panda
Copy link
Contributor Author

@mrsarm Thank you!

@njogz PR has been updated, it's ready for review :)

Copy link
Contributor

@njogz njogz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mrsarm mrsarm merged commit bba4d08 into master Jul 22, 2021
@mrsarm
Copy link
Contributor

mrsarm commented Jul 22, 2021

Ups I merged it before moving it to AT, although it doesn't introduce any code change, just static asset changes.

There is a alpha version waiting for test, so I'm going to replace that alpha with a new one with the latest changes introduced into master with this PR.

@mrsarm
Copy link
Contributor

mrsarm commented Jul 22, 2021

@latin-panda I added a note about the inclusion of these PR in the release testing: #164 (comment)

So once completed the testing we can mark this PR as verified by AT.

@ngaruko
Copy link
Contributor

ngaruko commented Jul 23, 2021

@latin-panda Wondering if, while we are on it, we should remove all references to medicmobile to use medic, ie things kile package name, application Id, and flavors named after medicmobile? Left a comment on #164

@latin-panda
Copy link
Contributor Author

@ngaruko good question, I think the package name, application ID and flavors can remain the same for now it's possible to have issues with Google Play because of the current apps in the store. Some other occurrences of medicmobile.org are because the server instances are still using medicmobile.org.

@mrsarm
Copy link
Contributor

mrsarm commented Jul 23, 2021

@latin-panda the alpha version passed the tests, so you can mark this also as done in the ticket.

@mrsarm mrsarm added this to the 0.9.0 milestone Aug 4, 2021
@mrsarm mrsarm linked an issue Aug 4, 2021 that may be closed by this pull request
@mrsarm mrsarm removed this from the 0.9.0 milestone Aug 4, 2021
@mrsarm mrsarm deleted the 7128-rebranding-icon branch October 1, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change developer address and company name in Google Play
4 participants