128 - Translations and messages improvements

[mrsarm]

• Add missed translations for some buttons and messages, and fixed others.
• Add French and Spanish translations.

Issue: #128

[mrsarm]

Hey @abbyad , would you mind to review?

Some of the changes you suggested were applied before, and I have fixed others here. I also added more French translations, and Spanish because although we don't use them, it's easy for me.

[abbyad]

Looks good! Made some minor edits, and also removed CHT-Core throughout since it isn't meant to be used as the branded tool. We should stick to "CHT server" or "CHT instance" as needed in the context.

On a related note, do we even need to say CHT, or would just something like "the server is not ready"? Keeping it generic might help if these messages are coming up on a rebranded app (eg partner branded instead of CHT branded).

[mrsarm]

Keeping it generic might help if these messages are coming up on a rebranded app (eg partner branded instead of CHT branded)

Totally agree, I have applied all the changes suggested, and checked there are no remaining CHT-Core references. Please take a look again.

[abbyad]

Keeping it generic might help if these messages are coming up on a rebranded app (eg partner branded instead of CHT branded)

Totally agree, I have applied all the changes suggested, and checked there are no remaining CHT-Core references. Please take a look again.

It seems as though we agree that the specific mentions to the CHT in these messages should be removed, is that already part of this PR? (I still see "CHT server is not ready, please try again soon")

[mrsarm]

It seems as though we agree that the specific mentions to the CHT in these messages should be removed, is that already part of this PR? (I still see "CHT server is not ready, please try again soon")

So so, I have changed all references of CHT-Core to just CHT or "server" depending of the context, @abbyad do you suggest to also replace "CHT server" for just "Server" ?

[abbyad]

Are these messages seen only when using the unbranded app? If so then CHT may be fine. But if a message like "CHT server is not ready, please try again soon" (errAppUrl_apiNotReady) can pop up for branded flavors, then we should avoid the use of "CHT" in that case. The other labels seem pretty specific to the unbranded flavor, so should be fine as they are already, but will let you be the judge on the others.

[mrsarm]

Yes @abbyad , all the translations that refers to CHT here are for the Unbranded flavor, and used when you try to setup the CHT instance URL, so I think we are fine, so if it is OK for you please give it the ✔️ .

[abbyad]

Nice work!