Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set user-agent header in Medic Collect #3334

Closed
alxndrsn opened this issue Apr 3, 2017 · 3 comments
Closed

Set user-agent header in Medic Collect #3334

alxndrsn opened this issue Apr 3, 2017 · 3 comments
Labels
Type: Bug Fix something that isn't working as intended

Comments

@alxndrsn
Copy link
Contributor

alxndrsn commented Apr 3, 2017

medic-collect does not currently set the User-Agent header in HTTP requests made to servers. This issue has recently been fixed upstream (getodk/collect#167), and we should backport this fix into our builds of Collect.

Support should also be added in medic-api's is-client-human tester

@alxndrsn
Copy link
Contributor Author

alxndrsn commented Apr 3, 2017

Open pull requests against medic-api and medic-collect; blocked by medic/medic-api#134

@alxndrsn
Copy link
Contributor Author

alxndrsn commented Apr 4, 2017

Cross-platform multilinguistic review, please! @garethbowen I think the JS code should be fairly obvious after your review of #3118; @abbyad you're the collect maestro.

alxndrsn added a commit to medic/medic-collect that referenced this issue Apr 4, 2017
@garethbowen garethbowen added the Type: Bug Fix something that isn't working as intended label Apr 4, 2017
@garethbowen
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix something that isn't working as intended
Projects
None yet
Development

No branches or pull requests

4 participants