Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes about 24 hour feedback for PR reviews. #863

Merged
merged 5 commits into from
Nov 21, 2022
Merged

Add notes about 24 hour feedback for PR reviews. #863

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f4f667
Add notes about 24 hour feedback for PR reviews.
Nov 21, 2022
385d1e9
Update content/en/contribute/code/workflow.md
craig-landry Nov 21, 2022
a9f9450
Update content/en/contribute/code/workflow.md
craig-landry Nov 21, 2022
27f877b
Update content/en/contribute/code/workflow.md
craig-landry Nov 21, 2022
3d4653c
Update content/en/contribute/code/workflow.md
craig-landry Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion content/en/contribute/code/workflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,19 @@ Aim for self-documenting code. Where code cannot be made self-documenting add co

A good workflow would be to work locally, pushing to a remote branch as you make progress, possibly open a draft PR for some initial collaboration on tricky parts, and once everything is done, convert the draft PR to a regular PR to be reviewed.

### Reviewing
### Code reviews

#### Guidelines

The author and reviewer should use this [guide to code reviewing](https://google.github.io/eng-practices/review/developer/).

#### Timeliness

Timely code reviews are important to getting improvements into the hands of users faster and allowing developers to stay focused on the task at hand and see it through to production.

Code reviews should be completed within 24 hours of assignment (excluding weekends and holidays). In some cases, a code review may not be possible if a larger discussion needs to be had for design choices or solution objectives, but even in cases like those, some feedback is still to be expected within 24 hours.


### Updating The Issue With What You Actually Did

Add [labels](https://github.com/medic/cht-core/labels) to the GitHub issue as needed. At this stage, the two to look out for are:
Expand Down