Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange existing docs into handbook top level dir #910

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

garethbowen
Copy link
Contributor

@garethbowen garethbowen requested a review from andrablaj December 9, 2022 01:50
@garethbowen
Copy link
Contributor Author

@andrablaj Review please. I've just rearranged the existing content. It might be easiest to review if you check it out and use hugo server to deploy it locally.

Copy link
Member

@andrablaj andrablaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Gareth! So nice to have the handbook starting! 🙌

I have a general question about the guides such as CHT Core Development Guide. I was wondering whether they should be added in the handbook too. It might be me being too new to the team, but I still find it challenging to navigate through the current content.
For example, what is the difference between Tutorials & Quick Guides? Maybe this needs a separate conversation/ticket, but would like to start that discussion too.

@mrjones-plip
Copy link
Contributor

Pro move with the aliases on this to ensure old linked content correctly redirects! 😍

@garethbowen
Copy link
Contributor Author

@mrjones-plip I learned from the best.

@garethbowen
Copy link
Contributor Author

I have a general question about the guides such as CHT Core Development Guide. I was wondering whether they should be added in the handbook too. It might be me being too new to the team, but I still find it challenging to navigate through the current content.

Good catch! I've moved this to the Contributor Handbook too.

For example, what is the difference between Tutorials & Quick Guides? Maybe this needs a separate conversation/ticket, but would like to start that discussion too.

Let's start that as a separate discussion - I agree those are too similar and we might consider merging them. I suggest bringing this up with Esther.

@garethbowen
Copy link
Contributor Author

@andrablaj I've incorporated your feedback - would you mind having another look?

Copy link
Member

@andrablaj andrablaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garethbowen garethbowen merged commit adc41e9 into main Dec 12, 2022
@garethbowen garethbowen deleted the 895-contributor-handbook branch December 12, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants