Skip to content

Commit

Permalink
Merge branch 'hotfix'
Browse files Browse the repository at this point in the history
  • Loading branch information
DrRobsAT committed Apr 2, 2024
2 parents 16e146a + 4016464 commit 6e72def
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 9 deletions.
2 changes: 1 addition & 1 deletion pyceps/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ def execute_commands(args):
if args.pkl_file and not study.is_root_valid():
logger.warning('a valid study root is necessary to import maps!')
else:
study.import_maps(study.mapNames,
study.import_maps(import_maps,
egm_names_from_pos=args.egm_from_pos)
# import lesion data for all loaded maps
for map_name in study.maps.keys():
Expand Down
2 changes: 1 addition & 1 deletion pyceps/datatypes/study.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def export_additional_meshes(self, *args, **kwargs):
def is_root_valid(self, root_dir=None):
raise NotImplementedError

def set_root(self, root_dir):
def set_repository(self, root_dir):
raise NotImplementedError

@classmethod
Expand Down
9 changes: 5 additions & 4 deletions pyceps/fileio/cartoio.py
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ def load(cls, filename, root=None):

# try to set root if explicitly given
if root:
if obj.set_root(os.path.abspath(root)):
if obj.set_repository(os.path.abspath(root)):
log.info('setting study root to {}'.format(root))
return obj
else:
Expand All @@ -665,14 +665,15 @@ def load(cls, filename, root=None):
.format(root))

# try to re-set previous study root
if obj.set_root(obj.repository.base):
if obj.set_repository(obj.repository.base):
log.info('previous study root is still valid ({})'
.format(obj.repository.root))
return obj

# no valid root found so far, set to pkl directory
log.warning('no valid study root found. Using .pkl location!'.upper())
obj.repository.update_root(os.path.dirname(os.path.abspath(filename)))
obj.repository.base = os.path.abspath(filename)
obj.repository.root = os.path.dirname(os.path.abspath(filename))
return obj

def export_additional_meshes(self, filename=''):
Expand Down Expand Up @@ -832,7 +833,7 @@ def is_root_valid(self, root_dir=None, pwd=''):

return False

def set_root(self, root_dir):
def set_repository(self, root_dir):
"""
Change path to root directory. Overrides BaseClass method.
If new root directory is invalid, it is not changed.
Expand Down
6 changes: 3 additions & 3 deletions pyceps/fileio/precisionio.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def is_root_valid(self, root_dir=None):
# specified root directory is valid
return True

def set_root(self, root_dir):
def set_repository(self, root_dir):
"""
Change path to root directory.
Expand Down Expand Up @@ -179,7 +179,7 @@ def load(cls, filename, root=None):

# try to set root if explicitly given
if root:
if obj.set_root(os.path.abspath(root)):
if obj.set_repository(os.path.abspath(root)):
log.info('setting study root to {}'.format(root))
return obj
else:
Expand All @@ -191,7 +191,7 @@ def load(cls, filename, root=None):
if obj.is_root_valid():
log.info('previous study root is still valid ({})'
.format(obj.studyRoot))
obj.set_root(os.path.abspath(obj.studyRoot))
obj.set_repository(os.path.abspath(obj.studyRoot))
return obj

# no valid root found so far, set to pkl directory
Expand Down

0 comments on commit 6e72def

Please sign in to comment.