fix(utils): bignumber util considers nullable options when setting value

.changeset/itchy-bags-play.md

@@ -0,0 +1,5 @@
+---
+"@medusajs/utils": patch
+---
+
+fix(utils): bignumber util considers nullable options when setting value

packages/cart/src/models/line-item-adjustment.ts

@@ -24,7 +24,7 @@ import LineItem from "./line-item"
 export default class LineItemAdjustment extends AdjustmentLine {
   @ManyToOne({
     entity: () => LineItem,
-    cascade: [Cascade.REMOVE, Cascade.PERSIST, "soft-remove"] as any,
+    cascade: [Cascade.PERSIST],
   })
   item: LineItem
 

packages/cart/src/models/shipping-method-adjustment.ts

@@ -20,7 +20,7 @@ import ShippingMethod from "./shipping-method"
 export default class ShippingMethodAdjustment extends AdjustmentLine {
   @ManyToOne({
     entity: () => ShippingMethod,
-    cascade: [Cascade.REMOVE, Cascade.PERSIST, "soft-remove"] as any,
+    cascade: [Cascade.PERSIST],
   })
   shipping_method: ShippingMethod
 

packages/utils/src/dal/mikro-orm/__tests__/big-number-field.spec.ts

@@ -1,6 +1,6 @@
-import { MikroOrmBigNumberProperty } from "../big-number-field"
 import { BigNumberRawValue } from "@medusajs/types"
 import { BigNumber } from "../../../totals/big-number"
+import { MikroOrmBigNumberProperty } from "../big-number-field"
 
 describe("@MikroOrmBigNumberProperty", () => {
   it("should correctly assign and update BigNumber values", () => {
@@ -9,6 +9,11 @@ describe("@MikroOrmBigNumberProperty", () => {
       amount: BigNumber | number
 
       raw_amount: BigNumberRawValue
+
+      @MikroOrmBigNumberProperty({ nullable: true })
+      nullable_amount: BigNumber | number | null = null
+
+      raw_nullable_amount: BigNumberRawValue | null = null
     }
 
     const testAmount = new TestAmount()
@@ -25,6 +30,16 @@ describe("@MikroOrmBigNumberProperty", () => {
       precision: 20,
     })
 
+    try {
+      ;(testAmount as any).amount = null
+    } catch (e) {
+      expect(e.message).toEqual(
+        "Invalid BigNumber value. Should be one of: string, number, BigNumber (bignumber.js), BigNumberRawValue"
+      )
+    }
+
+    testAmount.nullable_amount = null
+    expect(testAmount.nullable_amount).toEqual(null)
     // Update the amount
 
     testAmount.amount = 200

packages/utils/src/dal/mikro-orm/big-number-field.ts

@@ -1,6 +1,7 @@
-import { BigNumber } from "../../totals/big-number"
-import { Property } from "@mikro-orm/core"
 import { BigNumberInput } from "@medusajs/types"
+import { Property } from "@mikro-orm/core"
+import { isPresent } from "../../common"
+import { BigNumber } from "../../totals/big-number"
 
 export function MikroOrmBigNumberProperty(
   options: Parameters<typeof Property>[0] & {
@@ -16,21 +17,25 @@ export function MikroOrmBigNumberProperty(
         return this[targetColumn]
       },
       set(value: BigNumberInput) {
-        let bigNumber: BigNumber
+        let bigNumber: BigNumber | null = null
+
         if (value instanceof BigNumber) {
           bigNumber = value
         } else if (this[rawColumnName]) {
           const precision = this[rawColumnName].precision
           this[rawColumnName].value = new BigNumber(value, {
             precision,
           }).raw!.value
+
           bigNumber = new BigNumber(this[rawColumnName])
+        } else if (options.nullable && !isPresent(value)) {
+          bigNumber = null
         } else {
           bigNumber = new BigNumber(value)
         }
 
-        this[targetColumn] = bigNumber.numeric
-        this[rawColumnName] = bigNumber.raw
+        this[targetColumn] = bigNumber?.numeric ?? null
+        this[rawColumnName] = bigNumber?.raw ?? null
       },
     })