Skip to content

Commit

Permalink
chore: simple create/update factories for public services
Browse files Browse the repository at this point in the history
  • Loading branch information
@riqwan
riqwan committed Mar 20, 2024
1 parent 189b03c commit 8429f88
Show file tree
Hide file tree
Showing 2 changed files with 113 additions and 103 deletions.
78 changes: 10 additions & 68 deletions packages/pricing/src/services/pricing-module.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,21 @@ export default class PricingModuleService<
InjectedDependencies,
PricingTypes.PriceSetDTO,
{
MoneyAmount: { dto: PricingTypes.MoneyAmountDTO }
MoneyAmount: {
dto: PricingTypes.MoneyAmountDTO
create_dto: PricingTypes.CreateMoneyAmountDTO
update_dto: PricingTypes.UpdateMoneyAmountDTO
}
PriceSetMoneyAmount: { dto: PricingTypes.PriceSetMoneyAmountDTO }
PriceSetMoneyAmountRules: {
dto: PricingTypes.PriceSetMoneyAmountRulesDTO
}
PriceRule: { dto: PricingTypes.PriceRuleDTO }
RuleType: { dto: PricingTypes.RuleTypeDTO }
RuleType: {
dto: PricingTypes.RuleTypeDTO
create_dto: PricingTypes.CreateRuleTypeDTO
update_dto: PricingTypes.UpdateRuleTypeDTO
}
PriceList: { dto: PricingTypes.PriceListDTO }
PriceListRule: { dto: PricingTypes.PriceListRuleDTO }
}
Expand Down Expand Up @@ -705,72 +713,6 @@ export default class PricingModuleService<
)
}

@InjectTransactionManager("baseRepository_")
async createMoneyAmounts(
data: PricingTypes.CreateMoneyAmountDTO[],
@MedusaContext() sharedContext: Context = {}
) {
const moneyAmounts = await this.moneyAmountService_.create(
data,
sharedContext
)

return await this.baseRepository_.serialize<PricingTypes.MoneyAmountDTO[]>(
moneyAmounts,
{
populate: true,
}
)
}

@InjectTransactionManager("baseRepository_")
async updateMoneyAmounts(
data: PricingTypes.UpdateMoneyAmountDTO[],
@MedusaContext() sharedContext: Context = {}
) {
const moneyAmounts = await this.moneyAmountService_.update(
data,
sharedContext
)

return await this.baseRepository_.serialize<PricingTypes.MoneyAmountDTO[]>(
moneyAmounts,
{
populate: true,
}
)
}

@InjectTransactionManager("baseRepository_")
async createRuleTypes(
data: PricingTypes.CreateRuleTypeDTO[],
@MedusaContext() sharedContext: Context = {}
): Promise<PricingTypes.RuleTypeDTO[]> {
const ruleTypes = await this.ruleTypeService_.create(data, sharedContext)

return await this.baseRepository_.serialize<PricingTypes.RuleTypeDTO[]>(
ruleTypes,
{
populate: true,
}
)
}

@InjectTransactionManager("baseRepository_")
async updateRuleTypes(
data: PricingTypes.UpdateRuleTypeDTO[],
@MedusaContext() sharedContext: Context = {}
): Promise<PricingTypes.RuleTypeDTO[]> {
const ruleTypes = await this.ruleTypeService_.update(data, sharedContext)

return await this.baseRepository_.serialize<PricingTypes.RuleTypeDTO[]>(
ruleTypes,
{
populate: true,
}
)
}

@InjectTransactionManager("baseRepository_")
async createPriceSetMoneyAmountRules(
data: PricingTypes.CreatePriceSetMoneyAmountRulesDTO[],
Expand Down
138 changes: 103 additions & 35 deletions packages/utils/src/modules-sdk/abstract-module-service-factory.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,21 +33,49 @@ type BaseMethods =
| "delete"
| "softDelete"
| "restore"
| "create"
| "update"

const readMethods = ["retrieve", "list", "listAndCount"] as BaseMethods[]
const writeMethods = ["delete", "softDelete", "restore"] as BaseMethods[]
const writeMethods = [
"delete",
"softDelete",
"restore",
"create",
"update",
] as BaseMethods[]

const methods: BaseMethods[] = [...readMethods, ...writeMethods]

type ModelsConfigTemplate = {
[ModelName: string]: { singular?: string; plural?: string; dto: object }
[ModelName: string]: {
singular?: string
plural?: string
dto: object
create_dto?: object
update_dto?: object
}
}

type ExtractSingularName<
T extends Record<any, any>,
K = keyof T
> = T[K] extends { singular?: string } ? T[K]["singular"] : K

type CreateMethodName<
ModelConfig extends Record<any, any>,
ModelKey = keyof ModelConfig
> = ModelConfig[ModelKey] extends { create_dto?: object }
? `create${ExtractPluralName<ModelConfig, ModelKey>}`
: never

type UpdateMethodName<
ModelConfig extends Record<any, any>,
ModelKey = keyof ModelConfig
> = ModelConfig[ModelKey] extends { update_dto?: object }
? `update${ExtractPluralName<ModelConfig, ModelKey>}`
: never

type ExtractPluralName<T extends Record<any, any>, K = keyof T> = T[K] extends {
plural?: string
}
Expand All @@ -67,6 +95,11 @@ export interface AbstractModuleServiceBase<TContainer, TMainModelDTO> {
sharedContext?: Context
): Promise<TMainModelDTO>

create(
data: object | object[],
sharedContext?: Context
): Promise<TMainModelDTO>

list(
filters?: any,
config?: FindConfig<any>,
Expand Down Expand Up @@ -100,53 +133,41 @@ export interface AbstractModuleServiceBase<TContainer, TMainModelDTO> {
export type AbstractModuleService<
TContainer,
TMainModelDTO,
TOtherModelNamesAndAssociatedDTO extends ModelsConfigTemplate
ModelsConfig extends ModelsConfigTemplate
> = AbstractModuleServiceBase<TContainer, TMainModelDTO> & {
[K in keyof TOtherModelNamesAndAssociatedDTO as `retrieve${ExtractSingularName<
TOtherModelNamesAndAssociatedDTO,
K
> &
[K in keyof ModelsConfig as `retrieve${ExtractSingularName<ModelsConfig, K> &
string}`]: (
id: string,
config?: FindConfig<any>,
sharedContext?: Context
) => Promise<TOtherModelNamesAndAssociatedDTO[K & string]["dto"]>
) => Promise<ModelsConfig[K & string]["dto"]>
} & {
[K in keyof TOtherModelNamesAndAssociatedDTO as `list${ExtractPluralName<
TOtherModelNamesAndAssociatedDTO,
K
> &
[K in keyof ModelsConfig as `list${ExtractPluralName<ModelsConfig, K> &
string}`]: (
filters?: any,
config?: FindConfig<any>,
sharedContext?: Context
) => Promise<TOtherModelNamesAndAssociatedDTO[K & string]["dto"][]>
) => Promise<ModelsConfig[K & string]["dto"][]>
} & {
[K in keyof TOtherModelNamesAndAssociatedDTO as `listAndCount${ExtractPluralName<
TOtherModelNamesAndAssociatedDTO,
[K in keyof ModelsConfig as `listAndCount${ExtractPluralName<
ModelsConfig,
K
> &
string}`]: {
(filters?: any, config?: FindConfig<any>, sharedContext?: Context): Promise<
[TOtherModelNamesAndAssociatedDTO[K & string]["dto"][], number]
[ModelsConfig[K & string]["dto"][], number]
>
}
} & {
[K in keyof TOtherModelNamesAndAssociatedDTO as `delete${ExtractPluralName<
TOtherModelNamesAndAssociatedDTO,
K
> &
[K in keyof ModelsConfig as `delete${ExtractPluralName<ModelsConfig, K> &
string}`]: {
(
primaryKeyValues: string | object | string[] | object[],
sharedContext?: Context
): Promise<void>
}
} & {
[K in keyof TOtherModelNamesAndAssociatedDTO as `softDelete${ExtractPluralName<
TOtherModelNamesAndAssociatedDTO,
K
> &
[K in keyof ModelsConfig as `softDelete${ExtractPluralName<ModelsConfig, K> &
string}`]: {
<TReturnableLinkableKeys extends string>(
primaryKeyValues: string | object | string[] | object[],
Expand All @@ -155,17 +176,34 @@ export type AbstractModuleService<
): Promise<Record<string, string[]> | void>
}
} & {
[K in keyof TOtherModelNamesAndAssociatedDTO as `restore${ExtractPluralName<
TOtherModelNamesAndAssociatedDTO,
K
> &
[K in keyof ModelsConfig as `restore${ExtractPluralName<ModelsConfig, K> &
string}`]: {
<TReturnableLinkableKeys extends string>(
primaryKeyValues: string | object | string[] | object[],
config?: RestoreReturn<TReturnableLinkableKeys>,
sharedContext?: Context
): Promise<Record<string, string[]> | void>
}
} & {
[ModelName in keyof ModelsConfig as CreateMethodName<
ModelsConfig,
ModelName
>]: {
(
data: ModelsConfig[ModelName]["create_dto"][],
sharedContext?: Context
): Promise<ModelsConfig[ModelName]["dto"][]>
}
} & {
[ModelName in keyof ModelsConfig as UpdateMethodName<
ModelsConfig,
ModelName
>]: {
(
data: ModelsConfig[ModelName]["update_dto"][],
sharedContext?: Context
): Promise<ModelsConfig[ModelName]["dto"][]>
}
}

/**
Expand Down Expand Up @@ -211,7 +249,7 @@ export type AbstractModuleService<
export function abstractModuleServiceFactory<
TContainer,
TMainModelDTO,
TOtherModelNamesAndAssociatedDTO extends ModelsConfigTemplate
ModelsConfig extends ModelsConfigTemplate
>(
mainModel: Constructor<any>,
otherModels: ModelConfiguration[],
Expand All @@ -220,7 +258,7 @@ export function abstractModuleServiceFactory<
new (container: TContainer): AbstractModuleService<
TContainer,
TMainModelDTO,
TOtherModelNamesAndAssociatedDTO
ModelsConfig
>
} {
const buildMethodNamesFromModel = (
Expand Down Expand Up @@ -303,6 +341,40 @@ export function abstractModuleServiceFactory<

applyMethod(methodImplementation, 2)

break
case "create":
methodImplementation = async function <T extends object>(
this: AbstractModuleService_,
data = [],
sharedContext: Context = {}
): Promise<T[]> {
const service = this.__container__[serviceRegistrationName]
const entities = await service.create(data, sharedContext)

return await this.baseRepository_.serialize<T[]>(entities, {
populate: true,
})
}

applyMethod(methodImplementation, 2)

break
case "update":
methodImplementation = async function <T extends object>(
this: AbstractModuleService_,
data = [],
sharedContext: Context = {}
): Promise<T[]> {
const service = this.__container__[serviceRegistrationName]
const entities = await service.update(data, sharedContext)

return await this.baseRepository_.serialize<T[]>(entities, {
populate: true,
})
}

applyMethod(methodImplementation, 2)

break
case "list":
methodImplementation = async function <T extends object>(
Expand Down Expand Up @@ -524,9 +596,5 @@ export function abstractModuleServiceFactory<

return AbstractModuleService_ as unknown as new (
container: TContainer
) => AbstractModuleService<
TContainer,
TMainModelDTO,
TOtherModelNamesAndAssociatedDTO
>
) => AbstractModuleService<TContainer, TMainModelDTO, ModelsConfig>
}

0 comments on commit 8429f88

Please sign in to comment.