fix line item service

medusajs · Jan 2, 2024 · b5c9e04 · b5c9e04
1 parent 8859da5
commit b5c9e04
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/packages/medusa/src/services/line-item.ts b/packages/medusa/src/services/line-item.ts
@@ -505,15 +505,17 @@ class LineItemService extends TransactionBaseService {
           this.lineItemRepository_
         )
 
-        return (await lineItemRepository
-          .find({ where: { id: In(ids) } })
-          .then(
-            async (lineItems) =>
-              lineItems.length && lineItemRepository.remove(lineItems)
-          )
-          .then((lineItems) => {
-            return Array.isArray(id) ? lineItems : lineItems[0]
-          })) as TResult
+        const lineItems = await lineItemRepository.find({
+          where: { id: In(ids) },
+        })
+
+        let result
+        if (lineItems.length) {
+          await lineItemRepository.remove(lineItems)
+          result = Array.isArray(id) ? lineItems : lineItems[0]
+        }
+
+        return result as TResult
       }
     )
   }