Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pricing,utils,types): add operator field to price rule #10315

Merged
merged 4 commits into from
Nov 28, 2024
Merged

feat(pricing,utils,types): add operator field to price rule #10315

merged 4 commits into from
Nov 28, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Nov 27, 2024 •
edited
Loading

what:

  • adds an operator field to price rule with specific operator fields

RESOLVES CMRC-746

@riqwan riqwan requested a review from a team as a code owner November 27, 2024 12:14
@vercel Vercel
Copy link

vercel bot commented Nov 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 8:58am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Nov 28, 2024 8:58am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 8:58am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 8:58am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 8:58am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 8:58am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 8:58am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3187982

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riqwan riqwan force-pushed the feat/price-rule-operator branch from 84f5613 to 6e77b75 Compare November 27, 2024 12:15
@riqwan riqwan requested a review from olivermrbl November 27, 2024 12:16
olivermrbl
olivermrbl approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 3b1a63e into develop Nov 28, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/price-rule-operator branch November 28, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riqwan @olivermrbl