Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix French translation typos #10348

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Fix French translation typos #10348

merged 2 commits into from
Dec 3, 2024

Conversation

lucienbl
Copy link
Contributor

Hello,

This is just a small PR to fix a few typos with the French translation, especially with the template strings.

Best regards.

@lucienbl lucienbl requested a review from a team as a code owner November 28, 2024 11:10
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: eed1021

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 28, 2024

@lucienbl is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

kasperkristensen
kasperkristensen approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@kasperkristensen kasperkristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @lucienbl

@kodiakhq kodiakhq bot merged commit 56ae076 into medusajs:develop Dec 3, 2024
16 of 23 checks passed
hirotaka pushed a commit to hirotaka/medusa that referenced this pull request Dec 7, 2024
@lucienbl @hirotaka
Fix French translation typos (medusajs#10348)
5582d35 
Hello,

This is just a small PR to fix a few typos with the French translation, especially with the template strings.

Best regards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperkristensen kasperkristensen kasperkristensen approved these changes

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl olivermrbl is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucienbl @kasperkristensen