Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Japanese translation #10379

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

hirotaka
Copy link
Contributor

@hirotaka hirotaka commented Dec 1, 2024

This pull request adds support for the Japanese language in the MedusaJS Admin Dashboard.
Full translation, and json schema tests passed successfully

@hirotaka hirotaka requested a review from a team as a code owner December 1, 2024 04:24
Copy link

changeset-bot bot commented Dec 1, 2024

⚠️ No Changeset found

Latest commit: c247f5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 1, 2024

@hirotaka is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@hirotaka hirotaka changed the title Support Japanese translation feat: added Japanese translation Dec 1, 2024
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-ui ❌ Failed (Inspect) Dec 7, 2024 4:57am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2024 4:57am

@sradevski
Copy link
Member

ありがとうございます!

If you can rebase and add

 Missing required key: "adjustInventory" at /inventory
  Missing required key: "edit" at /orders
  Missing required key: "update_order" at /orders/activity/events
  Missing required key: "from" at /labels
  Missing required key: "to" at /labels
  Missing required key: "by" at /fields

I'll get it merged asap!

@hirotaka hirotaka force-pushed the japanese-translation branch from 38d6aaa to 1b30059 Compare December 7, 2024 04:45
@hirotaka hirotaka requested review from a team as code owners December 7, 2024 04:45
@hirotaka hirotaka force-pushed the japanese-translation branch from 1b30059 to 4cca0e0 Compare December 7, 2024 04:48
@hirotaka hirotaka closed this Dec 7, 2024
@hirotaka hirotaka force-pushed the japanese-translation branch from 4cca0e0 to c247f5b Compare December 7, 2024 04:54
@hirotaka
Copy link
Contributor Author

hirotaka commented Dec 7, 2024

@sradevski Thanks for review! I just added the missing required keys.

@sradevski sradevski merged commit 55f5ce4 into medusajs:develop Dec 7, 2024
29 of 38 checks passed
@hirotaka hirotaka deleted the japanese-translation branch December 8, 2024 02:46
jimrarras pushed a commit to jimrarras/medusa that referenced this pull request Jan 28, 2025
* feat: add Japanese language support

* feat: add missing required keys for Japanese translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants