feat(user): Migrate user module to DML #10389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6212ab3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 65 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
adrien2p
requested review from
christiananese,
carlos-r-l-rodrigues and
mrnbpt
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
adrien2p
commented
Dec 2, 2024
Comment on lines
-11
to
-26
| const expireDate = new Date().setMilliseconds( | ||
| new Date().getMilliseconds() + 60 * 60 * 24 | ||
| ) | ||
|
|
||
| const defaultInviteData = [ | ||
| { | ||
| id: "1", | ||
| email: "[email protected]", | ||
| token: "test", | ||
| expires_at: expireDate, | ||
| }, | ||
| { | ||
| id: "2", | ||
| email: "[email protected]", | ||
| token: "test", | ||
| expires_at: expireDate, |
There was a problem hiding this comment.
NOTE: The given value was overritten by the module so it was not doing anything
adrien2p
commented
Dec 2, 2024
| expires_at: new Date().setMilliseconds( | ||
| new Date().getMilliseconds() + this.config.expiresIn * 1000 | ||
| ), | ||
| expires_at: new Date(Date.now() + this.config.expiresIn * 1000), |
There was a problem hiding this comment.
NOTE: this was giving a big int instead of a date, now it does the same thing but provide a date instead
adrien2p
commented
Dec 2, 2024
Comment on lines
+318
to
328
| const id = generateEntityId((invite as { id?: string }).id, "invite") | ||
| return { | ||
| ...invite, | ||
| expires_at: new Date(), | ||
| token: "placeholder", | ||
| id, | ||
| expires_at: new Date(Date.now() + this.config.expiresIn * 1000), | ||
| token: this.generateToken({ id, email: invite.email }), | ||
| } | ||
| }) | ||
|
|
||
| const created = await this.inviteService_.create(toCreate, sharedContext) | ||
|
|
||
| const updates = created.map((invite) => { | ||
| return { | ||
| id: invite.id, | ||
| expires_at: new Date().setMilliseconds( | ||
| new Date().getMilliseconds() + this.config.expiresIn * 1000 | ||
| ), | ||
| token: this.generateToken({ id: invite.id, email: invite.email }), | ||
| } | ||
| }) | ||
|
|
||
| return await this.inviteService_.update(updates, sharedContext) | ||
| return await this.inviteService_.create(toCreate, sharedContext) | ||
| } |
There was a problem hiding this comment.
NOTE: This is a simplification, instead of doing a create and then an update, we only perform a create but the result remain unchanged
adrien2p
commented
Dec 2, 2024
Comment on lines
+6
to
+10
| this.addSql('drop index if exists "IDX_invite_email";'); | ||
| this.addSql('CREATE UNIQUE INDEX IF NOT EXISTS "IDX_invite_email_unique" ON "invite" (email) WHERE deleted_at IS NULL;'); | ||
|
|
||
| this.addSql('drop index if exists "IDX_user_email";'); | ||
| this.addSql('CREATE UNIQUE INDEX IF NOT EXISTS "IDX_user_email_unique" ON "user" (email) WHERE deleted_at IS NULL;'); |
There was a problem hiding this comment.
NOTE: this apply the right name based on convention
olivermrbl
reviewed
Dec 2, 2024
This was referenced Dec 2, 2024
Closed
hirotaka
pushed a commit
to hirotaka/medusa
that referenced
this pull request
Dec 7, 2024
* feat(user): Migrate user module to DML * Create rotten-tigers-worry.md * update indexes names following conventions * remove duplicate modifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RESOLVES FRMW-2817
What
Migrate user to DML