Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stock-location,core-flows,types): updates existing address when updating stock location #10832

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Jan 6, 2025

what:

When updating stock location address, currently it creates a new address on every update. This PR fixes that to do an upsert when there is an existing address.

RESOLVES CMRC-809

…pdating stock location address
Copy link

changeset-bot bot commented Jan 6, 2025

🦋 Changeset detected

Latest commit: cbd0a40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 65 packages
Name Type
@medusajs/stock-location Patch
@medusajs/core-flows Patch
@medusajs/types Patch
integration-tests-http Patch
@medusajs/dashboard Patch
@medusajs/medusa Patch
@medusajs/test-utils Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/promotion Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/framework Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch
@medusajs/cli Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch
@medusajs/telemetry Patch
@medusajs/admin-bundler Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 3:03pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 6, 2025 3:03pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2025 3:03pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2025 3:03pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2025 3:03pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2025 3:03pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2025 3:03pm

@riqwan riqwan changed the title fix(stock-location,core-flows,types): updates existing address when u… fix(stock-location,core-flows,types): updates existing address when updating stock location Jan 6, 2025
@riqwan riqwan marked this pull request as ready for review January 6, 2025 08:45
@riqwan riqwan requested a review from a team as a code owner January 6, 2025 08:45
@riqwan riqwan requested review from sradevski, fPolic and mrnbpt January 6, 2025 08:45
@riqwan riqwan merged commit 99a0610 into develop Jan 7, 2025
23 checks passed
@riqwan riqwan deleted the fix/stock-address branch January 7, 2025 06:55
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
noubase pushed a commit to noubase/medusa that referenced this pull request Jan 22, 2025
…pdating stock location (medusajs#10832)

* fix(stock-location,core-flows,types): updates existing address when updating stock location address

* chore: use hasOne instead of hasMany
jimrarras pushed a commit to jimrarras/medusa that referenced this pull request Jan 28, 2025
…pdating stock location (medusajs#10832)

* fix(stock-location,core-flows,types): updates existing address when updating stock location address

* chore: use hasOne instead of hasMany
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants