- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(admin-bundler,admin-vite-plugin,medusa): Add support for loading Admin Extensions from plugins #10869
Conversation
🦋 Changeset detectedLatest commit: abdd750 The changes in this PR will be included in the next version bump. This PR includes changesets to release 65 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
…n to admin-vite-plugin
…edusa into feat/admin-ext-plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, looping in @medusajs/framework in case they want to have a look at it.
|
||
export async function plugin() { | ||
const vite = await import("vite") | ||
const entries = await glob("src/admin/**/*.{ts,tsx,js,jsx}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: since node 22 we have the native glob API https://nodejs.org/api/fs.html#fsglobpattern-options-callback
maybe we can wait since we also support node 20 😅 but I wanted to mention it for reference
… Admin Extensions from plugins (medusajs#10869) Should not be merged before medusajs#10895 **What** - Introduces a new `plugin` command to `admin-bundler`, currently not used anywhere but will be called from `medusa build:plugin` - Discovers plugins with extensions and add passes the to `admin-vite-plugin`. - Updates `admin-vite-plugin` so its able to read built admin extensions. Resolves CMRC-830, CMRC-839
… Admin Extensions from plugins (medusajs#10869) Should not be merged before medusajs#10895 **What** - Introduces a new `plugin` command to `admin-bundler`, currently not used anywhere but will be called from `medusa build:plugin` - Discovers plugins with extensions and add passes the to `admin-vite-plugin`. - Updates `admin-vite-plugin` so its able to read built admin extensions. Resolves CMRC-830, CMRC-839
Should not be merged before #10895
What
plugin
command toadmin-bundler
, currently not used anywhere but will be called frommedusa build:plugin
admin-vite-plugin
.admin-vite-plugin
so its able to read built admin extensions.Resolves CMRC-830, CMRC-839