Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core-flows, dashboard, link-modules,medusa, types, utils): fulfillment shipping changes #10902

Merged
merged 54 commits into from
Jan 27, 2025
Merged

feat(core-flows, dashboard, link-modules,medusa, types, utils): fulfillment shipping changes #10902

merged 54 commits into from
Jan 27, 2025

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Jan 9, 2025 •
edited
Loading

What

  • product <> shipping profile link
  • create and update product workflows/endpoints accepts shipping profile
  • pass shipping option id when creating fulfillment to allow overriding customer selected SO
  • validate shipping profile delete
  • dashboard
    • set shipping profile on product create
    • manage shipping profile for a product
    • update the create fulfillment form
  • other
    • fix create product form infinite rerenders

CLOSES CMRC-831 CMRC-834 CMRC-836 CMRC-837 CMRC-838 CMRC-857 TRI-761

@fPolic fPolic requested a review from a team as a code owner January 9, 2025 17:30
@vercel Vercel
Copy link

vercel bot commented Jan 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 11:55am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 27, 2025 11:55am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 11:55am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 11:55am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 11:55am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 11:55am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 11:55am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: c41a8c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fPolic fPolic marked this pull request as draft January 9, 2025 17:31
@fPolic fPolic changed the title feat(core-flows, dashboard, link-modules,medusa, types): product shipping profile link feat(core-flows, dashboard, link-modules,medusa, types, utils): product shipping profile link Jan 9, 2025
@fPolic fPolic marked this pull request as ready for review January 10, 2025 15:46
fPolic added 2 commits January 13, 2025 10:29
@fPolic
Merge branch 'develop' into feat/product-shipping-profile-link
6ab1f6f 
# Conflicts:
#	packages/admin/dashboard/src/i18n/translations/$schema.json
#	packages/admin/dashboard/src/i18n/translations/en.json
@fPolic
fix: update i18n
739e8de
@fPolic
Merge branch 'develop' into feat/product-shipping-profile-link
ae2274c 
# Conflicts:
#	packages/core/core-flows/src/product/workflows/update-products.ts
#	packages/core/types/src/workflows/products/mutations.ts
@fPolic
Merge branch 'develop' into feat/product-shipping-profile-link
dd72332 
# Conflicts:
#	integration-tests/http/__tests__/cart/store/cart.spec.ts
fPolic added 2 commits January 22, 2025 18:00
@fPolic
Merge branch 'develop' into feat/product-shipping-profile-link
e8ae6ce 
# Conflicts:
#	packages/admin/dashboard/src/i18n/translations/$schema.json
@fPolic
fix: schema
24c72db
@fPolic fPolic requested a review from olivermrbl January 23, 2025 07:48
@kodiakhq kodiakhq bot merged commit 864d772 into develop Jan 27, 2025
24 checks passed
jimrarras pushed a commit to jimrarras/medusa that referenced this pull request Jan 28, 2025
@fPolic @jimrarras
feat(core-flows, dashboard, link-modules,medusa, types, utils): fulfi…
cfd6e6c 
…llment shipping changes (medusajs#10902)

**What**
- product <> shipping profile link
- create and update product workflows/endpoints accepts shipping profile
- pass shipping option id when creating fulfillment to allow overriding customer selected SO
- validate shipping profile delete
- dashboard
  - set shipping profile on product create
  - manage shipping profile for a product
  - **update the create fulfillment form**
- other
  - fix create product form infinite rerenders
 
---

CLOSES CMRC-831 CMRC-834 CMRC-836 CMRC-837 CMRC-838 CMRC-857 TRI-761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@adrien2p adrien2p adrien2p left review comments

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@mrnbpt mrnbpt Awaiting requested review from mrnbpt mrnbpt is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fPolic @olivermrbl @adrien2p