Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core-flows,types): improve tsdocs of workflows [1] #10940

Merged
merged 1 commit into from
Jan 13, 2025
Merged

chore(core-flows,types): improve tsdocs of workflows [1] #10940

merged 1 commit into from
Jan 13, 2025

Conversation

shahednasser
Copy link
Member

Improve the TSDocs of all workflows that support additional data [1]

@shahednasser shahednasser requested a review from a team as a code owner January 13, 2025 14:34
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: b308dee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 2:35pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 2:35pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Jan 13, 2025 2:35pm
docs-ui ⬜️ Ignored (Inspect) Jan 13, 2025 2:35pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 2:35pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 2:35pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 2:35pm

@shahednasser shahednasser merged commit 60dc8f6 into develop Jan 13, 2025
24 checks passed
@shahednasser shahednasser deleted the chore/workflows-ref-tsdocs-1 branch January 13, 2025 16:10
noubase pushed a commit to noubase/medusa that referenced this pull request Jan 22, 2025
@shahednasser @noubase
chore(core-flows,types): improve tsdocs of workflows [1] (medusajs#10940
61cfcd6 
)
jimrarras pushed a commit to jimrarras/medusa that referenced this pull request Jan 28, 2025
@shahednasser @jimrarras
chore(core-flows,types): improve tsdocs of workflows [1] (medusajs#10940
64dc7cf 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgirones sgirones Awaiting requested review from sgirones sgirones is a code owner automatically assigned from medusajs/engineering

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shahednasser