Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Include is default billing and shipping fields in the address re… #10970

Merged
merged 2 commits into from
Jan 15, 2025
Merged

fix: Include is default billing and shipping fields in the address re… #10970

merged 2 commits into from
Jan 15, 2025

Conversation

sradevski
Copy link
Member

FIXES #10959

@sradevski sradevski requested a review from a team as a code owner January 15, 2025 08:15
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0fa5254

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 5:36pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 5:36pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 5:36pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 5:36pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 5:36pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 5:36pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 5:36pm

@olivermrbl olivermrbl merged commit d845adc into develop Jan 15, 2025
23 checks passed
@olivermrbl olivermrbl deleted the fix/include-bools-address branch January 15, 2025 17:52
noubase pushed a commit to noubase/medusa that referenced this pull request Jan 22, 2025
@sradevski @olivermrbl @noubase
fix: Include is default billing and shipping fields in the address re…
4b7d795 
…sponse (medusajs#10970)

Co-authored-by: Oli Juhl <[email protected]>
jimrarras pushed a commit to jimrarras/medusa that referenced this pull request Jan 28, 2025
@sradevski @olivermrbl @jimrarras
fix: Include is default billing and shipping fields in the address re…
9cb1a99 
…sponse (medusajs#10970)

Co-authored-by: Oli Juhl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@mrnbpt mrnbpt Awaiting requested review from mrnbpt mrnbpt is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing is_default_billing and is_default_shipping when requesting addresses
3 participants
@sradevski @carlos-r-l-rodrigues @olivermrbl