Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improvements to payment module and Stripe provider #10980

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

sradevski
Copy link
Member

No description provided.

@sradevski sradevski requested a review from a team as a code owner January 15, 2025 14:39
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 9:19pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 9:19pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 9:19pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 9:19pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 9:19pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 9:19pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 9:19pm

Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: c7d43fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -300,25 +290,6 @@ abstract class StripeBase extends AbstractPaymentProvider<StripeOptions> {
}
}

async updatePaymentData(sessionId: string, data: Record<string, unknown>) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not part of the provider interface

@sradevski sradevski merged commit f523586 into develop Jan 16, 2025
23 checks passed
@sradevski sradevski deleted the feat/payment-improvements branch January 16, 2025 07:12
noubase pushed a commit to noubase/medusa that referenced this pull request Jan 22, 2025
)

* fix: Correctly parse Stripe error, remove unused method

* fix: Isolate the payment provider error check function

* fix: Allow passing few extra parameters to Stripe

---------

Co-authored-by: Oli Juhl <[email protected]>
jimrarras pushed a commit to jimrarras/medusa that referenced this pull request Jan 28, 2025
)

* fix: Correctly parse Stripe error, remove unused method

* fix: Isolate the payment provider error check function

* fix: Allow passing few extra parameters to Stripe

---------

Co-authored-by: Oli Juhl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants