You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If someone was using region_id from the payment collection entity, or cart_id, order_id, customer_id from the payment entity, they will no longer exist. Similarly, any code that was passing region_Id to createPaymentCollections would be recommended to remove the field.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@shahednasser I wasn't sure which parts of the docs need to be removed as well, I can do it if you point the places or you can just push here the necessary changes (or just open a new PR)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sradevski
force-pushed
the
feat/remove-payment-fields-break-abstraction
branch
from
BREAKING:
If someone was using
region_idfrom thepayment collectionentity, orcart_id,order_id,customer_idfrom thepaymententity, they will no longer exist. Similarly, any code that was passingregion_IdtocreatePaymentCollectionswould be recommended to remove the field.