Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core-flows): cart validate sales channel #11024

Merged
merged 6 commits into from
Jan 18, 2025
Merged

fix(core-flows): cart validate sales channel #11024

merged 6 commits into from
Jan 18, 2025

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Jan 17, 2025

What

  • validate that sales channel exist on cart create and update
  • fix a bug where default SC would be set on a cart on update if no SC was passed

CLOSES CMRC-810

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4479538

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 5:13pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 17, 2025 5:13pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 5:13pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 5:13pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 5:13pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 5:13pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 5:13pm

@fPolic fPolic marked this pull request as ready for review January 17, 2025 17:10
@fPolic fPolic requested a review from a team as a code owner January 17, 2025 17:10
olivermrbl
olivermrbl approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivermrbl olivermrbl merged commit c1385c7 into develop Jan 18, 2025
23 checks passed
noubase pushed a commit to noubase/medusa that referenced this pull request Jan 22, 2025
@fPolic @noubase
fix(core-flows): cart validate sales channel (medusajs#11024)
7c05c66
jimrarras pushed a commit to jimrarras/medusa that referenced this pull request Jan 28, 2025
@fPolic @jimrarras
fix(core-flows): cart validate sales channel (medusajs#11024)
1453541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fPolic @olivermrbl