fix(event): Subscriber ID miss usage #11047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a4143f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 65 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
@sradevski could you tell me what you think about this pr, it seems that the subscriber id was not used correctly or not at all in some cases 😂 |
sradevski
approved these changes
Jan 20, 2025
|
Can you add a description of the issue to the PR, i.e. how was it used wrong? |
@olivermrbl it was not used at all |
|
@olivermrbl should we merge this bad boy? |
Closed
noubase
pushed a commit
to noubase/medusa
that referenced
this pull request
Jan 22, 2025
PARTIALLY RESOLVES FRMW-2876 **What** Fix wrong usage of the `subscriberId` in the event bus. It happens that the subscriber id coming from the context was not used at all. This issue lead to duplicated event subscriber with the same subscriber id, it also prevent unsubscribing from event since rand id will be assigned. **NOTE** This PR does not handle overide strategy for subscribers with the same id. this still needs to be discussed
LeroySteding
pushed a commit
to LeroySteding/medusa-hifive
that referenced
this pull request
Jan 22, 2025
PARTIALLY RESOLVES FRMW-2876 **What** Fix wrong usage of the `subscriberId` in the event bus. It happens that the subscriber id coming from the context was not used at all. This issue lead to duplicated event subscriber with the same subscriber id, it also prevent unsubscribing from event since rand id will be assigned. **NOTE** This PR does not handle overide strategy for subscribers with the same id. this still needs to be discussed
jimrarras
pushed a commit
to jimrarras/medusa
that referenced
this pull request
Jan 28, 2025
PARTIALLY RESOLVES FRMW-2876 **What** Fix wrong usage of the `subscriberId` in the event bus. It happens that the subscriber id coming from the context was not used at all. This issue lead to duplicated event subscriber with the same subscriber id, it also prevent unsubscribing from event since rand id will be assigned. **NOTE** This PR does not handle overide strategy for subscribers with the same id. this still needs to be discussed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PARTIALLY RESOLVES FRMW-2876
What
Fix wrong usage of the
subscriberIdin the event bus. It happens that the subscriber id coming from the context was not used at all. This issue lead to duplicated event subscriber with the same subscriber id, it also prevent unsubscribing from event since rand id will be assigned.NOTE
This PR does not handle overide strategy for subscribers with the same id. this still needs to be discussed