Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(medusa,product,types): product type & tag store missing endpoints #11057

Merged
merged 6 commits into from
Jan 26, 2025
Merged

feat(medusa,product,types): product type & tag store missing endpoints #11057

merged 6 commits into from
Jan 26, 2025
+507 −3

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Jan 20, 2025

What

  • add GET /store/product-tags | GET /store/product-tags/:id
  • add GET /store/product-types | GET /store/product-types/:id

CLOSES CMRC-563

fPolic added 3 commits January 20, 2025 14:24
@fPolic
wip: tag endpoints
Loading
Loading status checks…
5661532
@fPolic
feat: types, product types
Loading
Loading status checks…
e3cd03d
@fPolic
feat: tests
Loading
Loading status checks…
c37a339
@fPolic fPolic requested a review from a team as a code owner January 20, 2025 15:33
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: fcfffc1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 2:40pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 25, 2025 2:40pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 25, 2025 2:40pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 25, 2025 2:40pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 25, 2025 2:40pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 25, 2025 2:40pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jan 25, 2025 2:40pm

@fPolic fPolic requested a review from olivermrbl January 20, 2025 19:11
olivermrbl
olivermrbl approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fPolic
fix: update product type schema
Loading
Loading status checks…
fcfffc1
@fPolic fPolic changed the title feat(medusa,types): product type & tag store missing endpoints feat(medusa,product,types): product type & tag store missing endpoints Jan 25, 2025
@olivermrbl olivermrbl merged commit d4cbc62 into develop Jan 26, 2025
23 checks passed
jimrarras pushed a commit to jimrarras/medusa that referenced this pull request Jan 28, 2025
@fPolic @jimrarras
feat(medusa,product,types): product type & tag store missing endpoints (
2d8064e 
medusajs#11057)

* wip: tag endpoints

* feat: types, product types

* feat: tests

* fix: update product type schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl

@christiananese christiananese

@carlos-r-l-rodrigues carlos-r-l-rodrigues

@kasperkristensen kasperkristensen

Assignees
No one assigned
Labels
team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fPolic @olivermrbl