Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for creating payment methods to payment module #11063

Merged
merged 2 commits into from
Jan 21, 2025
Merged

feat: Add support for creating payment methods to payment module #11063

merged 2 commits into from
Jan 21, 2025

Conversation

sradevski
Copy link
Member

CLOSES CLO-407

@sradevski sradevski requested a review from a team as a code owner January 20, 2025 16:46
@vercel Vercel
Copy link

vercel bot commented Jan 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 11:17am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 11:17am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 11:17am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 11:17am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 11:17am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 11:17am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 11:17am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2e0c875

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

adrien2p
adrien2p reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ve left a few comments, I am just wondering, does all providers support payments methods? If yes then LGTM otherwise should we handle that a bit differently such that those methods are not required to be implemented and the provider could have a method to tell if the payment methods is supported or not and handle that appropriately? wdyt?

packages/modules/payment/src/services/payment-module.ts Outdated Show resolved Hide resolved
packages/core/utils/src/payment/abstract-payment-provider.ts Outdated Show resolved Hide resolved
@sradevski sradevski requested a review from adrien2p January 21, 2025 10:32
@sradevski sradevski force-pushed the feat/add-support-create-payment-methods branch from 69d6110 to 7cebb74 Compare January 21, 2025 10:32
@sradevski sradevski force-pushed the feat/add-support-create-payment-methods branch from 7cebb74 to 1abc602 Compare January 21, 2025 11:10
@sradevski sradevski force-pushed the feat/add-support-create-payment-methods branch from 1abc602 to 2e0c875 Compare January 21, 2025 11:16
@kodiakhq kodiakhq bot merged commit 05c8a67 into develop Jan 21, 2025
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/add-support-create-payment-methods branch January 21, 2025 11:31
noubase pushed a commit to noubase/medusa that referenced this pull request Jan 22, 2025
@sradevski @noubase
feat: Add support for creating payment methods to payment module (med…
410d18c 
…usajs#11063)

CLOSES CLO-407
jimrarras pushed a commit to jimrarras/medusa that referenced this pull request Jan 28, 2025
@sradevski @jimrarras
feat: Add support for creating payment methods to payment module (med…
309ac2e 
…usajs#11063)

CLOSES CLO-407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p approved these changes

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sradevski @adrien2p