Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Fix position of Checkbox indicator #11075

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

kasperkristensen
Copy link
Contributor

What

  • Fixes an issue that would cause the Checkbox indicator to get rendered outside of view in the checkbox was wrapped in a relative div.

Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: d8bac6c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 66 packages
Name Type
@medusajs/ui Patch
@medusajs/dashboard Patch
@medusajs/admin-bundler Patch
@medusajs/medusa Patch
@medusajs/test-utils Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/promotion Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/core-flows Patch
@medusajs/framework Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/types Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch
@medusajs/cli Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch
@medusajs/telemetry Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch
integration-tests-http Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 10:28am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 22, 2025 10:28am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 10:28am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 10:28am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 10:28am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 10:28am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 10:28am

@kasperkristensen
Copy link
Contributor Author

@olivermrbl can you review this on behalf of UI when you get the chance?

Copy link
Contributor

olivermrbl commented Jan 22, 2025

Yes for sure. I will add @fPolic to the UI team, so you guys don't depend on my review going forward.

@kodiakhq kodiakhq bot merged commit 7feb004 into develop Jan 22, 2025
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/checkbox-indicator branch January 22, 2025 11:08
@github-actions github-actions bot mentioned this pull request Jan 22, 2025
noubase pushed a commit to noubase/medusa that referenced this pull request Jan 22, 2025
**What**
- Fixes an issue that would cause the Checkbox indicator to get rendered outside of view in the checkbox was wrapped in a relative div.
LeroySteding pushed a commit to LeroySteding/medusa-hifive that referenced this pull request Jan 22, 2025
**What**
- Fixes an issue that would cause the Checkbox indicator to get rendered outside of view in the checkbox was wrapped in a relative div.
jimrarras pushed a commit to jimrarras/medusa that referenced this pull request Jan 28, 2025
**What**
- Fixes an issue that would cause the Checkbox indicator to get rendered outside of view in the checkbox was wrapped in a relative div.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants