Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Move token from params to body #11281

Merged
merged 7 commits into from
Feb 26, 2025
Merged

chore: Move token from params to body #11281

merged 7 commits into from
Feb 26, 2025

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Feb 3, 2025 •
edited
Loading

What

  • Accept token for updating provider identity as a Bearer token instead of params
  • Remove deprecated actorType from reset-password event

Why

  • The authorization header is a more secure alternative as it avoids security risks such as leaking the token in logs

This is a breaking change; I decided to not make it backward compatible, as this is security-related.

@olivermrbl olivermrbl requested a review from a team as a code owner February 3, 2025 12:41
@vercel Vercel
Copy link

vercel bot commented Feb 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 10:45am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 10:45am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 10:45am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 10:45am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 10:45am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 10:45am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 10:45am
user-guide ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 10:45am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: cf3a5f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@olivermrbl olivermrbl force-pushed the chore/move-token-to-body branch from ad0195d to 4c9886a Compare February 4, 2025 08:14
@olivermrbl olivermrbl force-pushed the chore/move-token-to-body branch from 411b518 to 4bbb0c4 Compare February 13, 2025 07:54
@olivermrbl olivermrbl requested review from sradevski and christiananese and removed request for mrnbpt February 26, 2025 10:20
sradevski
sradevski approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@sradevski sradevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

christiananese
christiananese approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@christiananese christiananese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivermrbl olivermrbl merged commit 54a6ef9 into develop Feb 26, 2025
24 checks passed
@olivermrbl olivermrbl deleted the chore/move-token-to-body branch February 26, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahednasser shahednasser shahednasser left review comments

@sradevski sradevski sradevski approved these changes

@christiananese christiananese christiananese approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olivermrbl @sradevski @christiananese @shahednasser